This repository has been archived by the owner on Oct 1, 2024. It is now read-only.
[koa-shopify-auth] ➖ Remove the need for external safe-compare #1470
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
amorriscode
force-pushed
the
koa-shopify-auth/remove-safe-compare
branch
from
d615c5d
to
f52fb93
Compare
amorriscode
changed the title
amorriscode
force-pushed
the
koa-shopify-auth/remove-safe-compare
branch
2 times, most recently
from
ae02ddd
to
ddea5a1
Compare
amorriscode
force-pushed
the
koa-shopify-auth/remove-safe-compare
branch
from
ddea5a1
to
81eba78
Compare
|
Thank you for contributing to the ongoing improvement of this library - we really appreciate it. In order to optimize the support on this particular piece of functionality, we have moved it to its own repo. As a result, I’m closing this PR because the underlying source has been moved to a dedicated new repo; If you would like the PR to be considered for review, please re-create the change against the new Thank you! |
|
Sorry for the delay @mkevinosullivan but I ended up porting the change over. 👍 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes #1427
The
safe-comparewas an unneeded external dependency. This PR removes it and adds a file to do it without new deps.To test locally I built a new Shopify App and started a local dev server. I was able to install the app on my test store.
Type of change
Checklist